Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix extraction of Hailo userspace libs #15187

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix extraction of Hailo userspace libs #15187

wants to merge 1 commit into from

Conversation

sairon
Copy link

@sairon sairon commented Nov 25, 2024

Proposed change

The archive already has everything contained in a rootfs folder, extract it as-is to the root folder. This also reverts changes from 33957e5 which addressed the same issue in a less optimal way.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

@sairon
Fix extraction of Hailo userspace libs
ca4a845 
The archive already has everything contained in a rootfs folder, extract
it as-is to the root folder. This also reverts changes from
33957e5 which addressed the same issue
in a less optimal way.
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit ca4a845
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6744943ae52ec600073c5821
😎 Deploy Preview https://deploy-preview-15187--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sairon
Copy link
Author

sairon commented Nov 25, 2024

I can't assign reviewers (as requested in the linked issue), so at least pinging @NickM-27 and @blakeblackshear this way 🙏

@NickM-27
Copy link
Collaborator

In general I am not sure why this is behaving this way, theoretically at this stage it should be copying everything in /rootfs to /

frigate/docker/hailo8l/Dockerfile

Line 30 in 33957e5

COPY --from=hailort /rootfs/ /

@blakeblackshear
Copy link
Owner

I'm guessing that the tar.gz I generate includes the rootfs directory. This would result in it being extracted to /rootfs/rootfs/.

@sairon
Copy link
Author

sairon commented Nov 25, 2024

I'm guessing that the tar.gz I generate includes the rootfs directory. This would result in it being extracted to /rootfs/rootfs/.

Exactly:

$ tar -tvf /tmp/hailort-arm64.tar.gz 
drwxr-xr-x root/root         0 2024-11-01 14:11 rootfs/
drwxr-xr-x root/root         0 2024-11-01 14:11 rootfs/usr/
drwxr-xr-x root/root         0 2024-11-01 14:11 rootfs/usr/local/
drwxr-xr-x root/root         0 2024-11-01 14:11 rootfs/usr/local/bin/
-rwxr-xr-x root/root   4295728 2024-11-01 14:11 rootfs/usr/local/bin/hailortcli
drwxr-xr-x root/root         0 2024-11-01 14:11 rootfs/usr/local/lib/
-rw-r--r-- root/root   7261528 2024-11-01 14:11 rootfs/usr/local/lib/libhailort.so.4.19.0
-rw-r--r-- root/root   7261528 2024-11-01 14:11 rootfs/usr/local/lib/libhailort.so

That might be fixed in the libraries builder too (and I think it's the better way to move forward) but it would be a backward incompatible change. Also see the discussion in #15172 regarding the topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sairon @NickM-27 @blakeblackshear